<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix"><br>
On 05/27/2013 09:11 AM, Adam Chlipala wrote:<br>
</div>
<blockquote cite="mid:51A35B93.2020108@csail.mit.edu" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Looks pretty good to me! A few observations:<br>
<br>
- Why did you decide to parametrize your main functor over both a
mode
and a function from modes to CSS classes? The functor
implementation
seems to use the function and mode only by </blockquote>
<blockquote cite="mid:51A35B93.2020108@csail.mit.edu" type="cite">applying
the former to the
latter, so why not just pass in a CSS class?<br>
</blockquote>
You're right, the class selector function shouldn't be parametrized.
I do however want it to be parametrized by mode because I don't want
arbitrary css classes being passed in.<br>
<br>
<blockquote cite="mid:51A35B93.2020108@csail.mit.edu" type="cite">
- Personally, I'd opt for the identifier [navBarClass] over
[getNavBarClass], since the former feels more functional-ish.<br>
</blockquote>
Agreed. Still getting used to a declarative mindset.<br>
<br>
<blockquote cite="mid:51A35B93.2020108@csail.mit.edu" type="cite">
- There seem to be many extra blank lines at the end of the .ur
file.<br>
</blockquote>
Derp.<br>
<br>
On 05/23/2013 04:33 AM, David Snider wrote:
<blockquote cite="mid:51A35B93.2020108@csail.mit.edu" type="cite">
<blockquote cite="mid:519DD43E.2090508@davidsnider.net"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
I've started writing a library that wraps the 'gui' library to
produce
widgets styled with twitter bootstrap.<br>
I would appreciate if somebody could take a quick look at a
simple
example I've done and tell me if I am using the language
correctly.<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Thanks<br>
<br>
<a moz-do-not-send="true"
href="https://github.com/sniderd/bootstrap_gui">https://github.com/sniderd/bootstrap_gui</a><br>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Ur mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Ur@impredicative.com">Ur@impredicative.com</a>
<a class="moz-txt-link-freetext" href="http://www.impredicative.com/cgi-bin/mailman/listinfo/ur">http://www.impredicative.com/cgi-bin/mailman/listinfo/ur</a>
</pre>
</blockquote>
<br>
</body>
</html>